feat: include container name in error message. Fixes #10007 #13790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
changed the title
shuangkun
approved these changes
Oct 23, 2024
agilgur5
reviewed
Oct 27, 2024
agilgur5
reviewed
Oct 27, 2024
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: tooptoop4 <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: tooptoop4 <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: tooptoop4 <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
agilgur5
approved these changes
Oct 27, 2024
tczhao
reviewed
Oct 28, 2024
There was a problem hiding this comment.
I think this a breaking change, we better have a documentation for this.
I can imagine there exist users using conditional retry with exact matching on message
|
There are some libraries that consider errors as part of the API boundary, but we currently don't. This also isn't the first time we've changed an error.
Some libraries, like |
Signed-off-by: tooptoop4 <[email protected]>
added a note |
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: tooptoop4 <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: tooptoop4 <[email protected]>
tczhao
approved these changes
Nov 4, 2024
agilgur5
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10007