refactor(ui): simplify retry node by parametrizing retry workflow panel #13814
+40
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
area/ui
area/retry-manual
|
I couldn't request a review from @Adrien-D due to not being in the "members" team -- same reason as #8790 (comment) -- so tagging in this comment instead EDIT: now possible after #13813 (comment) |
agilgur5
force-pushed
the
refactor-ui-simplify-retry-node
branch
from
5d8294b to
690ad5a
Compare
added 4 commits
October 28, 2024 14:20
- parametrize based on the optional `props.nodeId` - slightly different heading and no field selector input, but otherwise the same - `props.onRetrySuccess` can actually be used in both variants - also ensure tooltip is in both - and improve wording a bit - disambiguate variable as `showRetryNodePanel` (missing "Panel" before) - fix types to not be optional in `workflow-node-info.tsx` and simplify code as such Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
- one less piece of state - nicer styling and nicer animation - less code too Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
force-pushed
the
refactor-ui-simplify-retry-node
branch
from
61bb038 to
4fbe16a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13343 (review)
Motivation
Simplifies and consolidates UI manual retry code -- 100+ LoC consolidated
Modifications
parametrize based on the optional
props.nodeIdprops.onRetrySuccesscan actually be used in both variantsuse the same retry panel element for both as (not just component)
Screenshots:
before:
after:
fix types to not be optional in
workflow-node-info.tsx(fixes feat(ui): Retry a single workflow step manually #13343 (comment)) and simplify code as suchplus a few small other simplifications as mentioned in my above linked review
Verification
Manually tested, works same as before, but with nicer styling + animation. See screenshots above