Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.6.0-rc3 CLI: Do not print help output on submission error #13826

Closed
3 of 4 tasks
jrussell9000 opened this issue Oct 28, 2024 · 1 comment · Fixed by #13831
Closed
3 of 4 tasks

3.6.0-rc3 CLI: Do not print help output on submission error #13826

jrussell9000 opened this issue Oct 28, 2024 · 1 comment · Fixed by #13831
Labels
area/cli The `argo` CLI type/bug type/regression Regression from previous behavior (a specific type of bug)
Milestone
v3.6.x patches

Comments

@jrussell9000
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

Previous versions (< 3.6) of the argo cli just output the error when a workflow submission failed. The current release candidate prints the error, followed by entire the help output. It's a bit tedious to have to scroll back up through all of this each time there's an error. Not sure if this is a bug or a feature request...

Version(s)

v3.6.0-rc3

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

argo submit 'ANYexampleworkflow.yaml'

Logs from the workflow controller

Not relevant to this issue.

Logs from in your workflow's wait container

Not relevant to this issue.
@agilgur5 agilgur5 changed the title Argo CLI - Do not print help output on submission error 3.6.0-rc3 CLI: Do not print help output on submission error Oct 28, 2024
@agilgur5 agilgur5 added type/regression Regression from previous behavior (a specific type of bug) area/cli The `argo` CLI labels Oct 28, 2024
@agilgur5 agilgur5 added this to the v3.6.0 milestone Oct 28, 2024
@agilgur5
Copy link

@MasonM can you take a look? This might be related to one of your CLI PRs or another recent CLI PR

MasonM added a commit to MasonM/argo-workflows that referenced this issue Oct 29, 2024
@MasonM
fix: don't print help for non-validation errors. Fixes argoproj#13826
0827ea5 
argoproj#13656 changed all CLI
commands to use `RunE` instead of `Run` and [cobra
validators](https://cobra.dev/#positional-and-custom-arguments). The
default behavior with Cobra is to print the help text for all errors,
which can be tedious to scroll through.

This changes the CLI to only print the help text for argument validation
errors, which should match the previous behavior.

Signed-off-by: Mason Malone <[email protected]>
@MasonM MasonM mentioned this issue Oct 29, 2024
Merged
Joibel pushed a commit that referenced this issue Oct 29, 2024
@MasonM
fix: don't print help for non-validation errors. Fixes #13826 (#13831)
39154fd 
Signed-off-by: Mason Malone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli The `argo` CLI type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
v3.6.x patches
Development

Successfully merging a pull request may close this issue.

fix: don't print help for non-validation errors. Fixes #13826 MasonM/argo-workflows
2 participants
@agilgur5 @jrussell9000