feat: add retry when kill container #7404
Conversation
henrywangx
changed the title
henrywangx
force-pushed
the
xiowang
branch
2 times, most recently
from
26663e0 to
f0db246
Compare
|
Please fix the failing builds. |
@terrytangyuan Done |
henrywangx
force-pushed
the
xiowang
branch
3 times, most recently
from
3aa6e8a to
8de0afa
Compare
alexec
changed the title
|
@terrytangyuan ready to re-review? |
| if err != nil { | ||
| return false, err | ||
| } |
There was a problem hiding this comment.
We probably only want to retry for transient errors?
cmd/argoexec/commands/wait.go
Outdated
| @@ -31,7 +35,21 @@ func waitContainer(ctx context.Context) error { | |||
| stats.StartStatsTicker(5 * time.Minute) | |||
|
|
|||
| defer func() { | |||
| if err := wfExecutor.KillSidecars(ctx); err != nil { | |||
| // Killing sidecar containers | |||
| retryCnt := 0 | |||
There was a problem hiding this comment.
We currently don't have retry counter in other places. It might be better to add later in all places where we are retrying.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Any update on this? |
Signed-off-by: henrywangx <[email protected]>
|
@terrytangyuan I have removed |
This comment was marked as spam.
This comment was marked as spam.
agilgur5
added
area/controller
The |
Since sometimes the connection between the APIServer is not stable. We don't want to rerun for this case.
So add retry to APIServer.
make pre-commit -Bto fix codegen, lint, and commit message problems.