feat: add debug logs to expressions #9533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Sep 9, 2022
util/template/expression_template.go
Outdated
| if (err != nil || result == nil) && allowUnresolved { // <nil> result is also un-resolved, and any error can be unresolved | ||
| if (err != nil || result == nil) && allowUnresolved { | ||
| // <nil> result is also un-resolved, and any error can be unresolved | ||
| log.WithError(err).Debug("unresolved is allowed ") |
There was a problem hiding this comment.
how do we know if we hit this branch, not line 26? Mayb add more message?
There was a problem hiding this comment.
@alexec , Should I be adding a separate message for each debug pointer - Like on line: 26, 36 and 42? and in simple_template.go, on line 53?
There was a problem hiding this comment.
When I look at the logs, I should be able to know which line of code the logging came from. If each message was different, that would work.
alexec
reviewed
Sep 9, 2022
|
@alexec , I have updated as per comments, Let me know if any further changes are required. |
alexec
approved these changes
Sep 13, 2022
|
Please sign off commits. |
surbhiahuja
force-pushed
the
improve-templating-diagnostics-8311
branch
from
4ecf2b1 to
1cc8e1e
Compare
alexec
changed the title
|
@alexec , can we please close this PR. |
|
This was superseded by #10741 |
agilgur5
added
area/templating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #TODO