docs: describe containerset retrystrategy and verify it works. Fixes: #11502

[shuangkun]

Fixes #11502

Motivation

Show how containerset retrystrategy works.

Modifications

Verification

e2e test

[tczhao]

Maybe add a note here

• https://github.com/argoproj/argo-workflows/blob/v3.5.5/pkg/apis/workflow/v1alpha1/container_set_template_types.go#L16
• https://github.com/argoproj/argo-workflows/blob/v3.5.5/docs/container-set-template.md

so that user can understand the behaviour from docs instead of going through the issue and PR

[shuangkun]

Maybe add a note here

• https://github.com/argoproj/argo-workflows/blob/v3.5.5/pkg/apis/workflow/v1alpha1/container_set_template_types.go#L16
• https://github.com/argoproj/argo-workflows/blob/v3.5.5/docs/container-set-template.md

so that user can understand the behaviour from docs instead of going through the issue and PR

Yes, it needs to be described more clearly in the comments and documentation. I will add more later. 🙏

[tczhao]

I should've caught this earlier, I think the test should be somewhere else instead of cli.
Imagine in CI when there's failure in cli test but totally unrelated to cli, this doesn't sound right.
What do you think?

[agilgur5]

/retest

#12864 has not been implemented yet, so that won't work yet.

@shuangkun shuangkun closed this 4 days ago
@shuangkun shuangkun reopened this 4 days ago

As I said in my previous comment, I will retry CI myself when this is ready to merge. No need to spend time getting E2Es to pass in the mean-time. Just need to make sure CI passes for docs + codegen for each change.

[agilgur5]

A few final changes here to account for the differences between a template-level retryStrategy and the inner containerSet.retryStrategy as discussed in a previous in-line comment

[shuangkun]

I modified it and fixed errors. Thanks!

[agilgur5]

I pushed a commit myself to fix the mkdocs-material admonition syntax with markdown inside of it as it's a bit complicated -- it requires a markdownlint-disable comment plus some proper newlines. That and I forgot that the "Note"'s title has to be in quotes. It looks like this now (as intended):

[agilgur5]

Thanks for adding these docs and iterating on this!

[shuangkun]

I pushed a commit myself to fix the mkdocs-material admonition syntax with markdown inside of it as it's a bit complicated -- it requires a markdownlint-disable comment plus some proper newlines. That and I forgot that the "Note"'s title has to be in quotes. It looks like this now (as intended):

OK,Thanks！