refactor: don't add configmap volumemounts in ARGO_TEMPLATE. Partial fix for #13089

workflow/controller/workflowpod.go

@@ -301,6 +301,43 @@ func (woc *wfOperationCtx) createWorkflowPod(ctx context.Context, nodeName strin
 	simplifiedTmpl.Inputs = wfv1.Inputs{
 		Artifacts: simplifiedTmpl.Inputs.Artifacts,
 	}
+
+	// simplify template by clearing useless volumemounts related to user configmaps ie somecode.py
+	if simplifiedTmpl.Container != nil && simplifiedTmpl.Container.VolumeMounts != nil {
+		var filteredVolumeMounts []apiv1.VolumeMount
+		for _, mnt := range simplifiedTmpl.Container.VolumeMounts {
+			isConfigMapVolume := false
+			for _, vol := range pod.Spec.Volumes {
+				if vol.Name == mnt.Name && vol.ConfigMap != nil && vol.Name != "argo-env-config" {
+					isConfigMapVolume = true
+					break
+				}
+			}
+			if isConfigMapVolume {
+				continue
+			}
+			filteredVolumeMounts = append(filteredVolumeMounts, mnt)
+		}
+		simplifiedTmpl.Container.VolumeMounts = filteredVolumeMounts
+	}
+	if simplifiedTmpl.Script != nil && simplifiedTmpl.Script.VolumeMounts != nil {
+		var filteredVolumeMountsScript []apiv1.VolumeMount
+		for _, mnt := range simplifiedTmpl.Script.VolumeMounts {
+			isConfigMapVolumeScript := false
+			for _, vol := range pod.Spec.Volumes {
+				if vol.Name == mnt.Name && vol.ConfigMap != nil && vol.Name != "argo-env-config" {
+					isConfigMapVolumeScript = true
+					break
+				}
+			}
+			if isConfigMapVolumeScript {
+				continue
+			}
+			filteredVolumeMountsScript = append(filteredVolumeMountsScript, mnt)
+		}
+		simplifiedTmpl.Script.VolumeMounts = filteredVolumeMountsScript
+	}
+
 	envVarTemplateValue := wfv1.MustMarshallJSON(simplifiedTmpl)
 
 	// Add standard environment variables, making pod spec larger