fix: use templateName where possible else nothing #13836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: isubasinghe <[email protected]>
Joibel
approved these changes
Oct 31, 2024
Adrien-D
added a commit
to pipekit/argo-workflows
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Adrien Delannoy <[email protected]>
Joibel
pushed a commit
to Joibel/argo-workflows
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Adrien Delannoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change ensures that we directly use the templateName first. In the case that we do not have this field, we then omit the template name all together.
Modifications
Use the node's
templateNamefield directly, else omit entirely.Verification
Tested on dags, steps and inline workflows.