REQUEST: Promotion to Reviewer for @jswxstw

[jswxstw]

GitHub Username

@jswxstw

Sub-project(s)

Promotion is requested for the following sub-project(s).

• Argo CD
• Argo Events
• Argo Rollouts
• Argo Workflows

Requirements

• Member for at least 3 months (as of the membership meeting date)
• Reviewer for or author of at least 5 substantial PRs to the codebase
  • refactor: Only set ARGO_TEMPLATE env for init container. argo-workflows#13761
  • fix: Mark task result as completed if pod has been deleted for a while. Fixes #13533 argo-workflows#13537
  • fix: Mark taskResult completed if wait container terminated not gracefully. Fixes #13373 argo-workflows#13491
  • fix: Only cleanup agent pod if exists. Fixes #12659 argo-workflows#13294
  • fix: Set initial progress from pod metadata if exists. Fixes #13057 argo-workflows#13260
  • fix: Mark Pending pod nodes as Failed when shutting down. Fixes #13210 argo-workflows#13214
  • fix: Task result comparison is incorrect, leading to inconsistent comparison results. argo-workflows#13211
  • fix: Do not reset the root node by default. Fixes #13196 argo-workflows#13198
  • fix: Only apply execution control to nodes that are not part of exit handler. argo-workflows#13016
  • fix: Set default value to output parameters if suspend node timeout. Fixes #12230 argo-workflows#12960
  • fix: Merge templateDefaults into dag task tmpl. Fixes #12821 argo-workflows#12833
  • fix: GC realtime metrics _after_ workflow completed. Fixes #12790 argo-workflows#12830
  • fix: Mark non-fulfilled taskSetNodes error when agent pod failed. Fixes #12703 argo-workflows#12723
  • fix: Patch taskset with subresources to delete completed node status. Fixes #11489 argo-workflows#12620
  • fix: Apply podSpecPatch in woc.execWf.Spec and template to pod sequentially argo-workflows#12476
  • fix: Apply workflow level PodSpecPatch in agent pod. Fixes #12387 argo-workflows#12440

Lead Sponsor(s)

Promotion to Reviewer requires sponsorship from at least one sub-project Lead.

• @terrytangyuan

Other Sponsors

• @Joibel

[Joibel]

+1 from me. jswxstw has some really good knowledge of the controller codebase. They already heavily contribute by adding valuable commentary on other people's PRs
I've edited the description to put myself as "Other Sponsors" and will await @juliev0 and @terrytangyuan publically commenting to re-add them to the description.

[terrytangyuan]

+1

[juliev0]

+1 @jswxstw has worked on some complicated PRs in the Controller and shows excellent logical reasoning. Highly recommend.