Don't unwrap when not synthesizing witness. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwared
reviewed
Mar 19, 2024
Signed-off-by: Thomas Chataigner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix argumentcomputer/bellpepper#90.
I've tested it against an arecibo branch @tchataigner supplied, and which reproduces the issue.
However, it would be best to have a local test demonstrating both the original problem and that this fixes it.
I believe @tchataigner is going to port
TestShapeCSfrom arecibo to bellpepper, after which the natural test of shape-only synthesis can be added to neptune.Ideally, this PR can then be rebased on a commit demonstrating the failing test. Then we can merge the result with reasonable confidence.