Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower values of fixed_log2_rows for the wrap machine #60

Open
wwared opened this issue Jun 19, 2024 · 0 comments
Open

Lower values of fixed_log2_rows for the wrap machine #60

wwared opened this issue Jun 19, 2024 · 0 comments

Comments

@wwared
Copy link
Contributor

wwared commented Jun 19, 2024

The values for fixed_log2_rows here were decreased from 20 to 19 upstream v1.0.6-testnet (and again at v1.0.7-testnet), but this breaks the test test_permutation_challenges in Sphinx, so we kept it at 20

Setting it to 19 does not break E2E Plonk proof generation however, in fact with it at 20 it prints the warning "WARN fixed log2 rows can be potentially reduced: got 394238, expected 1048576". We should double-check why test_permutation_challenges is failing with a lower size

Running a quick test benchmark with 19 vs 20 showed no meaningful difference in total proving time, but this number changes how big the final gnark circuit is, so we'll want to decrease it as much as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant