October 19, 2013 repeated on Saturday and Sunday

[machadoug]

Greetings,

One of my users found a bug in your script. October 19, 2013 repeated on Saturday and Sunday. Just to make sure it was not an error on my side I've checked you online demo and it also has the same issue.

How can I fix this?

Thanks in advanced for your help,

Douglas Machado

[lorenzos]

I was curious about it, and I checked the @arian demo here:

http://aryweb.nl/projects/mootools-datepicker/Test/

To me, October 19 2013 is not repeated. Where are you from? Maybe this is a problem relative to your specific Locale settings?

[machadoug]

Dear Lorenzos,

That's very strange. I can no longer reproduce the error. I should have taken a screenshot to prove it. ;-)
I'll ask the customer if he can reproduce this error.

Thanks for taking the time to look at it.

[machadoug]

Dear Lorenzos,

Please check this form below, field "Data do Evento"
http://www.douglasmelo.com/index.php/orcamento

Thanks for your help.

[lorenzos]

Looks ok to me. I see Saturday "Sab" 19 October "Out" 2013 only once.

[machadoug]

That's odd. This is what I see.

[machadoug]

Dear lorenzos,

I was able to find when exactly this is happening.

If you use MaxDate OR MinDate you will always get a problem in the third week of October, no matter the year. It is also happening in your demo site. Please see screenshot below:

I've looked at the code, but I could not find a solution for this issue.

I'd appreciate your assistance.

Best regards,

Douglas

[lorenzos]

I keep seeing the same correct calendar. What browser are you using? Maybe is a browser-specific bug?

At least now we have more informations for the future maintainers. Unfortunately arian has no time to fix bugs, as you can see on #138 ...

[machadoug]

Dear Lorenzos,

I'm sorry to hear that Arian is no longer maintaining this project. Unfortunately, I do not have the knowledge required to maintain such project.

That's odd. Did you test the last calendar in this page below?
http://aryweb.nl/projects/mootools-datepicker/Test/minmaxdate.html

I have just tested with IE10 and it works, however it does not work with FireFox 19.0.2, Google Chrome 25.0...

Best regards,

[machadoug]

Dear Lorenzos,

I have implemented a workaround. Probably not the best code:
https://www.dropbox.com/s/czvbohp7qfw6oy8/Picker.Date-uncompressed.js
Changes starts on line 498

I'm not familiar with git, so can you commit this code above?

Best regards,

[lorenzos]

I cannot commit anything, this is not a repository of mine. Good to know you solved, by the way ;-)

[arian]

@lorenzos if you create a pull request for this I can merge it. Or, perhaps, if you want commit access I can give it to you.

[lorenzos]

@arian Thanks Arian. I know you are searching for maintainers that work on issues and pull requests, but at the time I barely have the time to work only on project that I actually use in my job. I'm watching this repo, so if in the future I think I can handle it, I will contact you. Good luck!

[machadoug]

@arian,
I'd be happy to pull this request, but I've logged in and I could not find
a Pull request button as described on this page:
https://help.github.com/articles/creating-a-pull-request

Best regards,

[arian]

@machadoug see the first line on that page:

Before you can open a pull request, you must create a branch in your local repo, commit to it, and push the branch to a repo or fork on GitHub.

So you need to press the "fork" button first, then in your terminal

git clone git://urlofyourfork

make changes, commit and push to your fork of mootools-datepicker. Then the pull request button should appear.

---

It should also be possible to go to the JS file in this repository, press the edit button, fix it and then create a pull request, all through the GitHub UI. But usually when you make more changes than a simple typo fix, the previous approach is preferred :).

[machadoug]

@arian,
I'm not familiar with git (command line), so I've done it via GitHub UI. It
is not a very elegant fix, but it does the job.

All the best,

Douglas Machado