warn_missing_spec
#149
Merged
warn_missing_spec
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-ferraz-oliveira
force-pushed
the
feature/warn_missing_spec
branch
from
00f97e4 to
6c9eb16
Compare
williamthome
reviewed
Jul 4, 2024
There was a problem hiding this comment.
What do you think about closing #135 with this PR? We can open a specific issue for storing compiled templates.
Co-authored-by: William Fank Thomé <[email protected]>
paulo-ferraz-oliveira
force-pushed
the
feature/warn_missing_spec
branch
from
d090508 to
54288ea
Compare
williamthome
reviewed
Jul 6, 2024
williamthome
requested changes
Jul 6, 2024
williamthome
approved these changes
Jul 6, 2024
williamthome
added a commit
that referenced
this pull request
Jul 6, 2024
A function-line limit was introduced in #149. This commit just removes unuseful test lines. Tests will be improved later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
warn_missing_specand move stuff around for it. This is not the final interface, but a step in-between. I'll self-review by adding comments on decisions that are not immediately obvious.Closes #61. Closes #135.