-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spinner not updating with TypeScript LSP #15
Comments
I had this issue as well. Here is a pull request with a fix #20 |
The spinner works well in ts file now. Probably some updates on upstream made this issue fixed. |
@rockyzhang24 the spinner should be updating every 500 milliseconds https://github.com/arkav/lualine-lsp-progress/blob/master/lua/lualine/components/lsp_progress.lua#L25 |
@icholy Yes it works and updates as expected on my side. |
@rockyzhang24 which versions of neovim, lualine-lsp-progress, and typescript-langauge-server do you have installed? |
@icholy I cloned a large repo Screen.Recording.2022-05-16.at.07.22.26.mov |
@rockyzhang24 those are the begin / end progress notifications coming through. If you open a larger project (on a slower computer), you'll notice that it's not updating correctly. Your computer is loading the project so quickly that you're not seeing the issue. |
I just checked mine again and I am getting 1 update while |
@rockyzhang24 out of curiosity, what kind of machine (specs) are you running on? |
@icholy 16 inch MacBook Pro with M1 Pro, 32GB Memory + 1TB SSD. |
The spinner doesn't update when using typescript-language-server.
The LSP doesn't send
$/progress
reports aside frombegin
andend
(because the underlying tsserver doesn't support them). I proposed sending fake progress reports, but that wasn't accepted. typescript-language-server/typescript-language-server#373Is there a way to work around this?
The text was updated successfully, but these errors were encountered: