Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip optional/default type-level attributes on .required() #1160

Open
ssalbdivad opened this issue Oct 3, 2024 · 0 comments
Open

Strip optional/default type-level attributes on .required() #1160

ssalbdivad opened this issue Oct 3, 2024 · 0 comments

Comments

@ssalbdivad
Copy link
Member

This would fix the following case:

// https://github.com/arktypeio/arktype/issues/1156
it("with default", () => {
  const t = type({ foo: "string = 'bar'" }).required();

  const expected = type({
    foo: "string",
  });

  // currently the types do not match because the default is not removed
  attest<typeof expected.t, typeof t.t>();

  attest(t.expression).equals(expected.expression);
});

Should also add cases for optionality on the value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant