Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 api #103

Closed
wants to merge 140 commits into from
Closed

V1 api #103

wants to merge 140 commits into from

Conversation

arl
Copy link
Owner

@arl arl commented Jan 14, 2023

We will increase the major version number to v1 after this pull-request gets merged.

API changes:

  • do not use global state (global variables) anymore.
  • everything is based off a statsviz.Endpoint structure that users must instantiate, via statsviz.NewEndpoint()

TODO:

  • new API (based on statsviz.Endpoint)
  • update doc
  • update examples
  • expose API for the user to add their own plots

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (cca6221) 90.00% compared to head (50ca4bc) 63.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #103       +/-   ##
===========================================
- Coverage   90.00%   63.15%   -26.85%     
===========================================
  Files           3        2        -1     
  Lines          90      171       +81     
===========================================
+ Hits           81      108       +27     
- Misses          6       60       +54     
  Partials        3        3               
Files Coverage Δ
statsviz.go 78.86% <79.62%> (+10.67%) ⬆️
userplot.go 22.91% <22.91%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arl arl closed this Oct 7, 2023
@arl arl deleted the v1-api branch October 7, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant