Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: dt_makefile_patcher ignores dtb filenames with periods #7187

Closed
1 of 2 tasks
dust-7 opened this issue Sep 8, 2024 · 2 comments · Fixed by #7194
Closed
1 of 2 tasks

[Bug]: dt_makefile_patcher ignores dtb filenames with periods #7187

dust-7 opened this issue Sep 8, 2024 · 2 comments · Fixed by #7194
Labels
Bug Something isn't working as it should

Comments

@dust-7
Copy link
Contributor

dust-7 commented Sep 8, 2024

What happened?

File: https://github.com/armbian/build/blob/main/lib/tools/common/dt_makefile_patcher.py#L83

dt_makefile_patcher uses a regex to determine if a line in Makefile contains a dtb. The regex does not accept any line with a period before .dtb as a valid dtb. For example, px30-engicam-px30-core-edimm2.2.dtb from this Makefile is not created because of the period inside edimm2.2.

This issue blocks PR armbian/linux-rockchip#234.

How to reproduce?

Build command:
./compile.sh build BOARD=orangepi3b BRANCH=vendor BUILD_DESKTOP=no BUILD_MINIMAL=yes KERNEL_CONFIGURE=no RELEASE=noble

Branch

main (main development branch)

On which host OS are you running the build script and observing this problem?

Ubuntu 24.04 Noble

Are you building on Windows WSL2?

  • Yes, my Ubuntu/Debian/OtherOS is running on WSL2

Relevant log URL

https://paste.armbian.com/ibanuqalep

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dust-7 dust-7 added the Bug Something isn't working as it should label Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Jira ticket: AR-2484

@rpardini
Copy link
Member

rpardini commented Sep 8, 2024

Hmm, I guess this is valid -- albeit no mainline DT contains dots; who knows what else will break down the dot

Suggest you raise a PR -- should be around here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as it should
Development

Successfully merging a pull request may close this issue.

2 participants