Support newest consult, including breaking API change #47
Comments
|
@phaer Yes, I am aware of this, but it would take some time before I can update consult-omni and adapt to new changes. For now, you can use consult's stable release version 1.9: |
|
Just a wave here : same issue. So aborting testing consult-omni. I tested briefly with consult 1.9, ran consult-omni entered a phrase, hit return and got "apply: Args out of range: [], 0", so will revert to elpa consult. |
|
@rileyrg Sorry for the delay, there are a bunch of breaking changes that require some redesign of consult-omni. So, this can take a while! |
|
No worries. I just wanted you to know the version recommended didn't just
work. I'll pop back in a few months.
--
https://github.com/rileyrg
…On Tue, 21 Jan 2025, 13:07 Armin Darvish, ***@***.***> wrote:
@rileyrg <https://github.com/rileyrg> Sorry for the delay, there are a
bunch of breaking changes that require some redesign of consult-omni. So,
this can take a while!
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACYTC3ACDOATJBVDLSUIV32LYZ6PAVCNFSM6AAAAABUYRFVKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUGU2DOMBRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Not sure what you mean by vesion recommended. Unless you need the new changes in consult API, you can always use consult version 1.9 (which is the latest stable consult) and that should work. Other than that, just check back later. |
I can't wait any longer for Armin to catch up with consult breaking changes He needs to address armindarvish/consult-omni#47 sooner, all other consult packages seem to be caught up. I can't keep it pinned on the old version of consult, then I'd have to pin every single other package that depends on Consult. For the time being I'll have to live without conveniently searching for things with consult-omni
|
I wanted to try consult-omni, but it appears that consult 1.9 is no longer available. With consult 2.0, and installing consult-omni with |
|
I just pushed an update to the develop branch that should work with the new consult API. Note that this is likely going to be buggy right now and would need clean up, but it is a starting point. Because I am hacking |
|
@armindarvish very cool, thank you very much, I'm sorry, I didn't mean to nudge you about it, getting passive-aggressive like that, you don't owe us a single minute of your life - I honestly didn't realize that adding a reference in a commit message I made for my own posterity would be thrown at you like that. I just tried the update - basics appear to work, only Google and YouTube sources are not yielding any results for me. |
|
@agzam Not at all. Feel free to nudge. I am perfectly capable of ignoring things when I don'r have time.
Hmmm, That's weird. It is working for me. Now it's my turn to make work for you ;D. Can you please share your (setq consult-omni-log-level 'debug)and share the content of the log buffer (buffer name is stored in In addition try single source commands (e.g. Make sure you pull the latest from develop branch just to make sure we are on the smae commit. Thanks! |
Is your feature request related to a problem? Please describe.
I was about to test-drive consult-omni for my needs, as it looks like a very promising package.
Turns out my current consult is just a bit too recent for this, as there's been a breaking API change earlier today: https://github.com/minad/consult/blob/main/CHANGELOG.org#development
Describe the solution you'd like
I'd like to be able to run consult-omni with the latest consult
Additional context
The text was updated successfully, but these errors were encountered: