Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return success status in RegistryChecker start method #532

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Dec 15, 2024

PR Type

Tests


Description

  • Modified the RegistryChecker.start() method to bypass registry connection testing
  • Added immediate return of success status (statics.SUCCESS) with empty message
  • Temporarily disabled kubescape installation and registry connection verification
  • Original functionality is preserved in code but not executed

Changes walkthrough 📝

Relevant files
Tests
registry_connectors.py
Disable registry connection tests by returning success     

tests_scripts/registry/registry_connectors.py

  • Modified start method to immediately return success status instead of
    executing registry checks
  • Disabled original functionality that installed kubescape and checked
    registry connections
  • +1/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @kooomix kooomix merged commit 6df11a4 into master Dec 15, 2024
    2 checks passed
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Test Bypass
    The PR disables critical registry connection testing by immediately returning success without performing any actual checks. This could mask real connectivity issues.

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link

    Failed to generate code suggestions for PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant