Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update system_test_mapping.json to skip workflows Jira notifications …" #539

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Dec 16, 2024

User description

Reverts #538


PR Type

Enhancement


Description

  • Re-enabled Jira notifications workflows testing on all environments (staging, production, production-us)
  • Added descriptive text for the jira notifications workflows test case

Changes walkthrough 📝

Relevant files
Configuration changes
system_test_mapping.json
Update Jira notifications workflow configuration                 

system_test_mapping.json

  • Removed environment restrictions for jira notifications workflows
  • Added description field for jira notifications workflows test
  • +2/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @kooomix kooomix merged commit aa4f959 into master Dec 16, 2024
    3 checks passed
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Test Coverage
    Re-enabling Jira notifications testing on all environments may increase test coverage but could potentially impact production systems. Verify that these tests are safe to run in production.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Removing environment restrictions could cause test notifications to affect production systems

    Removing environment restrictions for Jira notifications workflows could lead to
    unintended notifications being sent in production environments. Consider keeping the
    environment restrictions to prevent test notifications from affecting production
    systems.

    system_test_mapping.json [1676]

    -"skip_on_environment": "",
    +"skip_on_environment": "staging,production,production-us",
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies a critical issue where removing environment restrictions could lead to test notifications being sent to production systems, potentially causing disruption to real users and workflows.

    9

    Copy link

    Failed to generate code suggestions for PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant