Update vulnerability message checks to include HTTP/2 in Slack and Te…

[kooomix]

User description

…ams workflows

---

PR Type

Tests

---

Description

• Updated test assertions in both Slack and Teams workflows to check for vulnerability messages containing either "http1" or "http2" protocols
• Modified string validation logic to be more inclusive of different HTTP protocol versions
• Ensures test coverage for vulnerability notifications across both HTTP/1 and HTTP/2 protocols

---

Changes walkthrough 📝

Relevant files

Tests

slack_workflows.py Add HTTP/2 protocol check in Slack vulnerability messages tests_scripts/workflows/slack_workflows.py Updated vulnerability message check to include both HTTP/1 and HTTP/2 protocols in message validation +1/-1      teams_workflows.py Add HTTP/2 protocol check in Teams vulnerability messages tests_scripts/workflows/teams_workflows.py Updated vulnerability message check to include both HTTP/1 and HTTP/2 protocols in message validation +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Test Coverage Verify that test cases exist for both HTTP/1 and HTTP/2 protocols separately to ensure each protocol version is properly tested Code Duplication Consider extracting the common vulnerability message validation logic into a shared helper method since it's duplicated between Slack and Teams workflows

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
General	Implement case-insensitive string matching for more robust protocol validation Add case-insensitive string matching for protocol checks to handle variations like 'HTTP1', 'Http1', etc. Use lower() method before comparison. tests_scripts/workflows/slack_workflows.py [160] -if "New Vulnerability found" in message_string and cluster in message_string and ("http1" in message_string or "http2" in message_string) and namespace in message_string: +message_string_lower = message_string.lower() +if "New Vulnerability found" in message_string and cluster in message_string and ("http1" in message_string_lower or "http2" in message_string_lower) and namespace in message_string: Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion improves robustness by handling different case variations of protocol strings (HTTP1, Http1, etc.), which is a good defensive programming practice for string matching in tests.	7
	Implement case-insensitive string matching for consistent protocol validation across different messaging platforms Add case-insensitive string matching for protocol checks to maintain consistency with the Slack workflow implementation and handle protocol string variations. tests_scripts/workflows/teams_workflows.py [191] -if "New Vulnerability found" in message_string and cluster in message_string and ("http1" in message_string or "http2" in message_string): +message_string_lower = message_string.lower() +if "New Vulnerability found" in message_string and cluster in message_string and ("http1" in message_string_lower or "http2" in message_string_lower): Apply this suggestion Suggestion importance[1-10]: 7 Why: Similar to the Slack workflow suggestion, this improves test reliability by handling case variations in protocol strings, ensuring consistent behavior across both messaging platforms.	7

[github-actions]

Failed to generate code suggestions for PR