Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update target repositories in system_test_mapping.json to use dummy s… #548

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Dec 31, 2024

User description

…uffix


PR Type

Enhancement


Description

  • Modified target repository names in system test mapping configuration by appending '-dummy' suffix
  • Updated repository names for public registry connectivity tests (both regular and excluded)
  • Affected repositories: cadashboardbe, event-ingester-service, gateway

Changes walkthrough 📝

Relevant files
Configuration changes
system_test_mapping.json
Update test repository names with dummy suffix                     

system_test_mapping.json

  • Updated target repositories names by adding '-dummy' suffix to
    'cadashboardbe', 'event-ingester-service', and 'gateway'
  • Changes applied to both regular and excluded public registry
    connectivity test configurations
  • +6/-6     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Update

    Verify that all systems and components are properly configured to handle the new '-dummy' suffixed repository names and that no references to the old repository names remain elsewhere in the codebase

        "cadashboardbe-dummy",
        "event-ingester-service-dummy",
        "gateway-dummy"
      ],
      "description": "checks public registry scan capabilities",
      "skip_on_environment": "",
      "owner": ""
    },
    "vuln_scan_test_public_registry_connectivity_excluded_by_backend": {
      "target": [
        "Backend",
        "In cluster"
      ],
      "target_repositories": [
        "cadashboardbe-dummy",
        "event-ingester-service-dummy",
        "gateway-dummy"

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Improve configuration documentation by explaining the purpose of dummy test repositories

    Consider adding a comment or updating the description field to explain why these
    repositories use the '-dummy' suffix and what it signifies for testing purposes.
    This will help other developers understand the testing configuration.

    system_test_mapping.json [166-171]

     "target_repositories": [
       "cadashboardbe-dummy",
    -  "event-ingester-service-dummy", 
    +  "event-ingester-service-dummy",
       "gateway-dummy"
     ],
    -"description": "checks public registry scan capabilities",
    +"description": "checks public registry scan capabilities using dummy test repositories",
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: The suggestion to update the description field to explain the '-dummy' suffix would improve documentation clarity, though it's a relatively minor enhancement that doesn't affect functionality.

    5

    Copy link

    Failed to generate code suggestions for PR

    @kooomix kooomix merged commit 4bfc8e1 into master Dec 31, 2024
    3 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants