Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old registry scan tests #573

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

amirmalka
Copy link
Contributor

@amirmalka amirmalka commented Jan 8, 2025

PR Type

Tests, Enhancement


Description

  • Removed outdated registry scan test imports and references.

  • Streamlined registry_tests.py by reducing unused imports.

  • Likely additional changes in backend, helm scripts, and documentation.

  • Updated system test mapping and configurations.


Changes walkthrough 📝

Relevant files
Tests
2 files
registry_tests.py
Removed unused imports and outdated references.                   
+1/-4     
vuln_scan_tests.py
Modifications in vulnerability scan test cases.                   
+0/-104 
Enhancement
4 files
backend_api.py
Updates likely related to backend API adjustments.             
+0/-386 
vuln_scan.py
Adjustments in vulnerability scan helm script.                     
+0/-475 
base_vuln_scan.py
Base vulnerability scan script refinements.                           
+0/-174 
kubectl_wrapper.py
Likely updates to kubectl wrapper functionalities.             
+0/-9     
Configuration changes
1 files
system_test_mapping.json
Updated system test mapping configurations.                           
+0/-43   
Documentation
1 files
readme.md
Documentation updates related to removed tests.                   
+0/-3     
Additional files
8 files
Jenkinsfile-helm-ks-be-test.groovy +0/-246 
Jenkinsfile-helm-ks-be.groovy +0/-255 
Jenkinsfile_helm_chart.groovy +0/-219 
Jenkinsfile_helm_chart_on_going_features.groovy +0/-205 
Jenkinsfile_kubescape.groovy +0/-210 
Jenkinsfile_payment.groovy +0/-200 
Jenkinsfile_relevancy.groovy +0/-210 
Jenkinsfile_single_test.groovy +0/-214 

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Code Cleanup

Removal of registry scan tests should be accompanied by cleanup of any remaining registry scan related code in the test configuration classes and helper methods.

    deployment=join("nginx-vuln-scan-new-image.yaml"),
    expected_results="nginx-new-image.json",
    exceptions_parameters={"namespace": "*/*"},
    helm_kwargs={"triggerNewImageScan": True},
)
API Cleanup

Consider cleaning up any remaining registry scan related API endpoint constants and methods that are no longer needed after removing the registry scan functionality.

API_REPOSITORYPOSTURE = "/api/v1/repositoryPosture"
API_REPOSITORYPOSTURE_REPOSITORIES = "/api/v1/repositoryPosture/repositories"
API_REPOSITORYPOSTURE_FILES = "/api/v1/repositoryPosture/files"
API_REPOSITORYPOSTURE_RESOURCES = "/api/v1/repositoryPosture/resources"

API_FRAMEWORK = "/api/v1/framework"

API_CUSTOMERCONFIGURATION = "/api/v1/customerConfiguration"

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@amirmalka amirmalka requested a review from kooomix January 8, 2025 13:50
Copy link

github-actions bot commented Jan 8, 2025

Failed to generate code suggestions for PR

@amirmalka amirmalka merged commit c10d076 into master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants