-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually install Android SDK, disable UI tests, build tools 23.0.3 → 26.0.2. #224
Manually install Android SDK, disable UI tests, build tools 23.0.3 → 26.0.2. #224
Conversation
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=============================================
- Coverage 77.89% 36.83% -41.07%
- Complexity 41 44 +3
=============================================
Files 39 39
Lines 561 524 -37
Branches 27 27
=============================================
- Hits 437 193 -244
- Misses 92 322 +230
+ Partials 32 9 -23
Continue to review full report at Codecov.
|
|
||
script: | ||
- bash build.sh | ||
- ./build.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chmod +x
, + separate invocation of bash
didn't pass ANDROID_HOME
declared above (that's expected bash behavior)
@@ -5,6 +5,8 @@ set -xe | |||
PROJECT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | |||
|
|||
# This will: compile the project, run lint, run tests under JVM, package apk, check the code quality and run tests on the device/emulator. | |||
"$PROJECT_DIR"/gradlew --no-daemon --info clean | |||
"$PROJECT_DIR"/gradlew --no-daemon --info build -PdisablePreDex -PwithDexcount -Dscan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember reason why did we run clean
in separate invocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting
Had to update build-tools version, otherwise build crashed (I suppose
language: android
took care of system dependencies for old version of aapt):@vanniktech PTAL