Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually install Android SDK, disable UI tests, build tools 23.0.3 → 26.0.2. #224

Merged
merged 1 commit into from
Oct 22, 2017

Conversation

artem-zinnatullin
Copy link
Owner

Had to update build-tools version, otherwise build crashed (I suppose language: android took care of system dependencies for old version of aapt):

:app:mergeDebugResourcesjava.io.IOException: Cannot run program "/home/travis/android-sdk/build-tools/23.0.3/aapt": error=2, No such file or directory
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
	at com.android.builder.png.AaptProcess$Builder.start(AaptProcess.java:167)
	at com.android.builder.png.QueuedCruncher$1.creation(QueuedCruncher.java:116)
	at com.android.builder.tasks.WorkQueue.run(WorkQueue.java:203)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.IOException: error=2, No such file or directory
	at java.lang.UNIXProcess.forkAndExec(Native Method)
	at java.lang.UNIXProcess.<init>(UNIXProcess.java:247)
	at java.lang.ProcessImpl.start(ProcessImpl.java:134)
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
	... 4 more

@vanniktech PTAL

@codecov-io
Copy link

codecov-io commented Oct 22, 2017

Codecov Report

Merging #224 into master will decrease coverage by 41.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #224       +/-   ##
=============================================
- Coverage     77.89%   36.83%   -41.07%     
- Complexity       41       44        +3     
=============================================
  Files            39       39               
  Lines           561      524       -37     
  Branches         27       27               
=============================================
- Hits            437      193      -244     
- Misses           92      322      +230     
+ Partials         32        9       -23
Impacted Files Coverage Δ Complexity Δ
...atters/developer_settings/DevMetricsProxyImpl.java 0% <0%> (-100%) 0% <0%> (ø)
...mzin/qualitymatters/models/PicassoImageLoader.java 0% <0%> (-100%) 0% <0%> (ø)
...rs/developer_settings/DeveloperSettingsModule.java 0% <0%> (-100%) 0% <0%> (-10%)
...ava/com/artemzin/qualitymatters/api/ApiModule.java 0% <0%> (-100%) 0% <0%> (-3%)
...emzin/qualitymatters/ui/adapters/ItemsAdapter.java 0% <0%> (-100%) 0% <0%> (ø)
...com/artemzin/qualitymatters/ApplicationModule.java 0% <0%> (-100%) 0% <0%> (-7%)
...artemzin/qualitymatters/network/NetworkModule.java 0% <0%> (-100%) 0% <0%> (-2%)
...in/qualitymatters/performance/AsyncJobsModule.java 0% <0%> (-100%) 0% <0%> (-2%)
...qualitymatters/other/EntityTypeAdapterFactory.java 0% <0%> (-100%) 0% <0%> (ø)
...alitymatters/network/OkHttpInterceptorsModule.java 0% <0%> (-100%) 0% <0%> (-4%)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d4529...bfb1fb6. Read the comment docs.

@artem-zinnatullin artem-zinnatullin changed the title Manually install Android SDK, disable UI tests. Manually install Android SDK, disable UI tests, build tools 23.0.3 → 26.0.2. Oct 22, 2017

script:
- bash build.sh
- ./build.sh
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chmod +x, + separate invocation of bash didn't pass ANDROID_HOME declared above (that's expected bash behavior)

@@ -5,6 +5,8 @@ set -xe
PROJECT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

# This will: compile the project, run lint, run tests under JVM, package apk, check the code quality and run tests on the device/emulator.
"$PROJECT_DIR"/gradlew --no-daemon --info clean
"$PROJECT_DIR"/gradlew --no-daemon --info build -PdisablePreDex -PwithDexcount -Dscan
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember reason why did we run clean in separate invocation

@artem-zinnatullin
Copy link
Owner Author

Well, UI tests indeed cover lots of app code that works with Android framework

screen shot 2017-10-22 at 00 05 49

Copy link
Contributor

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

@artem-zinnatullin artem-zinnatullin merged commit bab2d88 into master Oct 22, 2017
@artem-zinnatullin artem-zinnatullin deleted the az/manually-install-sdk-disable-ui-tests branch October 22, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants