Web chat #6
Open
Web chat #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// </summary> | ||
| public Client(string host, int port) | ||
| { | ||
| _client = new TcpClient(host, port); |
There was a problem hiding this comment.
Так TcpClient сразу начнёт подключаться к хосту, синхронно. Правильнее было создать TcpClient конструктором без параметров, а потом, уже в RunAsync, вызвать ConnectAsync.
Comment on lines
+16
to
+17
| await Task.Run(async () => await Post(stream)); | ||
| await Task.Run(async () => await Get(stream)); |
There was a problem hiding this comment.
Так мы сначала должны будем дождаться выполнения Post, а уже затем переходить к Get. Что не очень для чата. Надо было
var task1 = Post(stream);
var task2 = Get(stream);
await task1;
await task2;Есть большая разница, когда делать await
| await writer.FlushAsync(); | ||
| await stream.FlushAsync(); | ||
|
|
||
| writer = null; |
There was a problem hiding this comment.
Бесполезно, всё равно его перетрёт тут же
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.