Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothie crashes when loading fabrica while file is playing #24

Open
adeebshihadeh opened this issue Jun 21, 2016 · 2 comments
Open

Smoothie crashes when loading fabrica while file is playing #24

adeebshihadeh opened this issue Jun 21, 2016 · 2 comments

Comments

@adeebshihadeh
Copy link
Contributor

Loading the config while the file is playing crashes smoothie. A possible solution for this would be to use progress instead of version for the initial check. Then if it knows that a file is being played, it can get the config with cat /sd/config. The issue with cat is that there is about a 10 second pause in playing the file which can be detrimental to whatever is being made, especially for printers and lasers. Another solution would be to skip getting the config initially if a file is being played and use the updater module to get it once it notices that the file is done being played and sees that the config is missing.

@arthurwolf
Copy link
Owner

The user should never load/reload the interface while a print is going on.
The only thing that should be called while a print is going on, is /command
And even then, no "cat" should be issued.
The config file should be grabbed only once at the beginning, and never while playing

This is a limitation of the current Ethernet stuff and I don't think it'll change before v2.

@adeebshihadeh
Copy link
Contributor Author

There are cases when the user may not be the one reloading. For example, if windows decided to update itself and you had a tab with fabrica open in chrome, after the update, chrome will automatically open and load your previous tabs. Perhaps if the user reloads while a file is being played, it will take them to the screen to monitor the print and once the print is done, it tells them to reload to get the full UI, or it reloads itself. Besides, if the config is cached, it isn't critical to retrieve it every time as users most likely use config-override once the initial config is together. the only thing the whole config is used for is the configuration screens anyway.

Repository owner deleted a comment from tobarbaro Jan 1, 2024
Repository owner deleted a comment from tobarbaro Jan 1, 2024
Repository owner deleted a comment from tobarbaro Jan 1, 2024
Repository owner deleted a comment from tobarbaro Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants