Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does AllowInserts is correct value? #147

Open
Kation opened this issue Apr 12, 2023 · 0 comments
Open

Does AllowInserts is correct value? #147

Kation opened this issue Apr 12, 2023 · 0 comments

Comments

@Kation
Copy link

Kation commented Apr 12, 2023

var allowInserts = p.ValueGenerated == ValueGenerated.Never || p.GetAfterSaveBehavior() == PropertySaveBehavior.Save;

According to this line, allow insert when property is not set as value generated or save behavior on update.

I think it should be

var allowInserts = p.ValueGenerated == ValueGenerated.Never && p.GetBeforeSaveBehavior() == PropertySaveBehavior.Save;

It must not set as value generated and save behavior on add.

And why mysql runner does not use this field to generate sql?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant