Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Ability to Disable Block #102

Open
chrisvidal opened this issue May 22, 2023 · 6 comments
Open

Feature Request: Add Ability to Disable Block #102

chrisvidal opened this issue May 22, 2023 · 6 comments

Comments

@chrisvidal
Copy link
Contributor

to be bale to disable a block.

helpful for testing purpose when client is not sure if he wants to remove a block or not and see how it looks.

that would avoid to delete the block and hen have to redo it again later on.

@artistro08
Copy link
Owner

Excellent Suggestion. I'd take pull requests for this if it fits the following criteria:

  • The switch for each block is put inside the column_options.yaml and section_header.yaml files
  • The logic for the switch should live in the builder.htm and section.htm partial files.
  • The switch should appear under the "General" tab at the bottom of the block.

@chrisvidal
Copy link
Contributor Author

ok let me confirm a few things.

point 1: you are referring to the columns here and not the block, is that correct? you want to have the switch as well in the columns options on top of the blocks?

point 2: yes i agree the logic should be in the builder.html file for the blocks, and also the section.htm file for the columns

for the point 3, I think you mean to put the switch at the top of the General Tab and not at the bottom, correct?

@chrisvidal
Copy link
Contributor Author

I made a PR to add the disabled capacity at the blocks levels first.

@artistro08
Copy link
Owner

Point 1: The Column options yaml file contains the content that is re-used throughout the blocks (bad naming convention there I know)

Point 2: Awesome

Point 3: I think it would look better at the bottom since it won't be as used as the other options but still needs to be there.

@chrisvidal
Copy link
Contributor Author

I updated the section_header.yaml blueprint to add the swith on the block. I didnt use column_options.

@artistro08
Copy link
Owner

The switch should exist on both the section and the column blocks. Would add granular control.

@artistro08 artistro08 changed the title Feature suggestion Add Ability to Disable Block Oct 11, 2023
@artistro08 artistro08 changed the title Add Ability to Disable Block Feature Request: Add Ability to Disable Block Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants