fixed code review suggestions

artsy · Nov 11, 2024 · 7fdc9ee · 7fdc9ee
1 parent 08747fd
commit 7fdc9ee
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/src/app/Scenes/Onboarding/Auth2/scenes/LoginWelcomeStep.tsx b/src/app/Scenes/Onboarding/Auth2/scenes/LoginWelcomeStep.tsx
@@ -232,28 +232,19 @@ const SocialLoginButtons: React.FC = () => {
         {Platform.OS === "ios" && osMajorVersion() >= 13 && (
           <Button variant="outline" onPress={handleApplePress}>
             <Flex alignItems="center" justifyContent="center">
-              <AppleIcon width="23px" height="23px" style={{ position: "relative", top: 4 }} />
+              {/* On iOS, the icons need to be nudged down to be centered in the button. */}
+              <AppleIcon width={23} height={23} style={{ top: 4 }} />
             </Flex>
           </Button>
         )}
-
         <Button variant="outline" onPress={handleGooglePress}>
           <Flex alignItems="center" justifyContent="center">
-            <GoogleIcon
-              width="23px"
-              height="23px"
-              style={Platform.OS === "ios" && { position: "relative", top: 4 }}
-            />
+            <GoogleIcon width={23} height={23} style={Platform.OS === "ios" && { top: 4 }} />
           </Flex>
         </Button>
-
         <Button variant="outline" onPress={handleFacebookPress}>
           <Flex alignItems="center" justifyContent="center">
-            <FacebookIcon
-              width="23px"
-              height="23px"
-              style={Platform.OS === "ios" && { position: "relative", top: 4 }}
-            />
+            <FacebookIcon width={23} height={23} style={Platform.OS === "ios" && { top: 4 }} />
           </Flex>
         </Button>
       </Flex>