build(deps): bump react-native from 0.73.10 to 0.75.4 #10995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
changed the title
… citypicker Co-authored-by: Brian Beckerle <[email protected]>
gkartalis
force-pushed
the
gkartalis/bump-rn-74
branch
from
5e6b6cd
to
551832f
Compare
gkartalis
commented
Nov 5, 2024
gkartalis
commented
Nov 5, 2024
| postNotificationName: noop("postNotificationName"), | ||
| didFinishBootstrapping: () => null, | ||
| reactStateUpdated: () => null, | ||
| getConstants: () => ({}), | ||
| getConstants: () => null as any, |
There was a problem hiding this comment.
I went with this as it was in line 130 to avoid solving extra type issues but it is not ideal
|
ios-8.56.0-2024.11.07.09 android-8.56.0-1674645923 |
gkartalis
commented
Nov 7, 2024
brainbicycle
reviewed
Nov 7, 2024
brainbicycle
reviewed
Nov 7, 2024
ios/Artsy/Emission/ViewControllers/ARMapComponentViewController.m
Outdated
Show resolved
Hide resolved
brainbicycle
reviewed
Nov 7, 2024
ios/Artsy/Emission/ViewControllers/ARMapContainerViewController.m
Outdated
Show resolved
Hide resolved
brainbicycle
reviewed
Nov 7, 2024
brainbicycle
reviewed
Nov 7, 2024
brainbicycle
reviewed
Nov 7, 2024
brainbicycle
reviewed
Nov 7, 2024
brainbicycle
reviewed
Nov 7, 2024
brainbicycle
reviewed
Nov 7, 2024
brainbicycle
reviewed
Nov 7, 2024
Co-authored-by: Brian Beckerle <[email protected]>
Co-authored-by: Brian Beckerle <[email protected]>
gkartalis
commented
Nov 11, 2024
| @@ -587,6 +587,9 @@ export class GlobalMap extends React.Component<Props, State> { | |||
| {...mapProps} | |||
| onRegionIsChanging={this.onRegionIsChanging} | |||
| onDidFinishRenderingMapFully={this.onDidFinishRenderingMapFully} | |||
| attributionEnabled | |||
| logoEnabled | |||
| logoPosition={{ bottom: 150, left: 10 }} | |||
Co-authored-by: Brian Beckerle <[email protected]>
brainbicycle
approved these changes
Nov 11, 2024
|
Impressive effort 👏👏👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Bumps
react-nativeversion from0.73.10to0.75.4.Removed Patches:
Bumped Dependencies:
@gorhom/bottom-sheet@react-native-async-storage/async-storage"@react-native-mapbox-gl/maps": "8.5.0"removed in favor of"@rnmapbox/maps": "10.1.31",@shopify/flash-list@stripe/stripe-react-nativemotireact-native-reanimatedRemoved Dependencies:
Flipper related stuff and react devtools (the react dev tools are still acessible with
npx react-devtools"deprecated-react-native-prop-types": "4.1.0","react-devtools-core""rn-flipper-async-storage-advanced": "1.0.5","redux-flipper": "2.0.2","react-native-flipper": "0.265.0","react-native-flipper-performance-plugin": "0.4.0","react-native-flipper-relay-devtools": "1.0.3",Important
Flipper is decoupled from react native - we will run a survey to see if we need to bring it back or not
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.