fix(ONYX-1375): fix SellWithArtsyRecentlySold Rail layout #11015
Conversation
| @@ -103,7 +104,9 @@ const RecentlySoldArtworksRail: React.FC<RecentlySoldArtworksRailProps> = ({ | |||
| onPress={() => { | |||
| onPress?.(item, index) | |||
| }} | |||
| metaContainerStyles={{ height: 100 }} | |||
| metaContainerStyles={{ | |||
| height: ARTWORK_RAIL_TEXT_CONTAINER_HEIGHT + 10, | |||
There was a problem hiding this comment.
question: Where does this + 10 come from?
There was a problem hiding this comment.
I think PixelRatio.getFontScale() cannot recognize when the Estimate goes into two lines, so we need to add the extra line height manually (10 is enough even tho the line height of the text is 20)
There was a problem hiding this comment.
Could we achieve the same by making the overflow visible (e.g. overflow: visible)? I would prefer this solution instead of adding padding for this special case. Or we could make the height of the meta text container flexible which would be the most natural way for me to solve the issue (imagine the text needs to have 3 or 4 lines which could theoretically happen). 🤔
There was a problem hiding this comment.
same thought here - You can also set the metaCardHeight to 110 if 100 is not enough
| @@ -103,7 +104,9 @@ const RecentlySoldArtworksRail: React.FC<RecentlySoldArtworksRailProps> = ({ | |||
| onPress={() => { | |||
| onPress?.(item, index) | |||
| }} | |||
| metaContainerStyles={{ height: 100 }} | |||
| metaContainerStyles={{ | |||
| height: PixelRatio.getFontScale() * 100, | |||
dariakoko
added
the
Squash On Green
artsy-peril
bot
deleted the
dariakoko/fix-SellWithArtsyRecentlySold-rail-layout
branch
This PR resolves ONYX-1375
Description
After the latest redesign and refactoring the UI of the SellWithArtsyRecentlySold Rail does not look correct.
Let’s adjust it to make the data on the artwork card assessable
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.