fix(DIA-981)(DIA-937): Auth2 QA Omnibus (Continued) #11083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <Image source={require("images/apple.webp")} /> | ||
| <Button variant="outline" onPress={handleApplePress}> | ||
| <Flex alignItems="center" justifyContent="center"> | ||
| <AppleIcon width="23px" height="23px" style={{ position: "relative", top: 4 }} /> |
There was a problem hiding this comment.
few changes here:
- there's no
pxin native development, let's use these props as numberswidth={23}instead. - Maybe add a comment about why top with 4 was needed
- position by default is
relativein RN, so I'm not sure ifpositionis necessary here https://reactnative.dev/docs/layout-props#position
the same goes to the other icons
There was a problem hiding this comment.
I'm not sure if
positionis necessary here
By George, you're right!
iskounen
force-pushed
the
iskounen/fix/auth2-qa-omnibus-continued
branch
from
59d4f46
to
7fdc9ee
Compare
| <Button variant="outline" onPress={handleApplePress}> | ||
| <Flex alignItems="center" justifyContent="center"> | ||
| {/* On iOS, the icons need to be nudged down to be centered in the button. */} | ||
| <AppleIcon width={23} height={23} style={{ top: 4 }} /> |
There was a problem hiding this comment.
if it's iOS only, then shouldn't we check the platform here too as we do in the other icons?
There was a problem hiding this comment.
No, because we only show the Apple option on iOS, so it would be redundant to add the check here.
artsyit
pushed a commit
that referenced
this pull request
Nov 11, 2024
* resized social icons and aligned them * Finished catch-all error message * added sentry event for social sign-in errors * let metaphysics determine my IP address * fixed code review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves DIA-981 DIA-937
Description
This PR continues fixes for the auth2 QA issues:
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.