feat: Add Availability filter to artwork filters #11100
Merged
+210
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
force-pushed
the
olerichter00/ONYX-880/availability-filter
branch
2 times, most recently
from
4671133
to
1e69e4a
Compare
olerichter00
commented
Nov 25, 2024
| @@ -140,6 +143,7 @@ export const ParamDefaultValues = { | |||
| colors: [], | |||
| earliestCreatedYear: undefined, | |||
| estimateRange: "", | |||
| forSale: undefined, | |||
There was a problem hiding this comment.
Setting the filter to undefined and not false by default. I guess both versions work, but false seems to be correct because we don't want to filter anything if the filter is not set.
olerichter00
changed the title
anandaroop
previously approved these changes
Nov 25, 2024
|
|
||
| export const OPTIONS: FilterData[] = [ | ||
| { | ||
| displayText: "Only Works for Sale", |
There was a problem hiding this comment.
suggestion (non-blocking): Probably match the casing on web?
Suggested change
| displayText: "Only Works for Sale", | |
| displayText: "Only works for sale", |
olerichter00
force-pushed
the
olerichter00/ONYX-880/availability-filter
branch
from
1e69e4a
to
90af525
Compare
Good catch! It looks like the artwork count does not get updated at all when applying any filter. I'll create a bug ticket in Jira. |
olerichter00
added
the
Squash On Green
olerichter00
force-pushed
the
olerichter00/ONYX-880/availability-filter
branch
from
5768c53
to
139a77b
Compare
artsy-peril
bot
deleted the
olerichter00/ONYX-880/availability-filter
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-880
Description
This PR adds the Availability filter to artwork grids on the artist screen. I'll implement the filter for more screens in an upcoming PR.
AREnableAvailabilityFilterPR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.