-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for caching both body and headers in Garner::Mixins::Rack #54
Comments
What would the API for a feature like this look like, in your opinion? I want to be careful not to complicate the API too much to support this feature. |
+1 for this feature. Without it, I can't use Garner because we send Pagination info via the Link header and other custom headers which clients that consume our API rely on. I'll try @dblock's patch in the meantime. |
Garner doesn't support this out of the box. I applied this monkey patch: artsy/garner#54
Garner doesn't support this out of the box. I applied this monkey patch: artsy/garner#54
+1 Same here. Issues with pagination info in the header |
+1 Same issue with header cache |
+1 |
We have monkey patched the Rack mixin to allow caching both headers and body, like this:
It should be possible to roll this functionality into Garner. The
Identity
part should probably become more generic to store data and metadata, while the Rack mixin would just reuse that functionality.The text was updated successfully, but these errors were encountered: