Set empty value for NodeSelector

[shubhamcoc]

Is it possible to set empty value for NodeSelector?
Use case: If we want to generate helm chart with default values as empty for NodeSelector.

Let me know, if it is possible currently.

[arttor]

Hi, @shubhamcoc, thank you for submitting the issue. I forgot to mention it in the documentation but i try to follow these rules for introducing new issues:

• backward compatibility - don't change the structure of already templated fields
• enforce Helm best practice and security
• don't add fields that are not presented in the source manifests. Users can shape helmify output only by modifying source, or using helmify flags. If we add non-existing fields and values to charts, users won't be able to remove them by editing source manifests if needed.

[arttor]

Can your problem be solved by adding nodeSelector to the source manifest?

We can add flag for empty nodeSelector but this approach does not scales well. It is hard to manage a big amount of flags to control all spec fields in k8s objects individually. In this case, it makes sense to start working on a detailed config like proposed in #59

[shubhamcoc]

Hi @arttor, If we add to the source manifest, and the nodeSelector is empty valued. helmify is omitting it in the generated charts and value.yaml file.

[arttor]

can you please give more info about your use-case? For example, if you are using kubebuilder project with kustomize, then nodeSelector maybe be somehow supported in your kustomize config.

We can introduce a flag adding nodeSelector to a chart (disabled by default) but in this case, it makes sense to cover other pod scheduling features like affinity. What do you think?

[shubhamcoc]

Hi @arttor, the nodeSelector field is present in the source manifest. It is getting omitted because it is empty. (For example: nodeSelector: {}), now here the map len is zero but the field is present. I hope it clarifies your doubt.

[arttor]

@shubhamcoc in this case we can replace if len(spec.NodeSelector) != 0 { to if spec.NodeSelector != nil in pkg/processor/pod/pod.go:76 and it should solve the issue. Is it correct?

[shubhamcoc]

@arttor, Yes you are right. Let me change in the PR as well.

[shubhamcoc]

@arttor, done with the changes. Can you review it once? Thanks!!

[arttor]

@shubhamcoc thank you for your contribution. changes are available in v0.4.1 release.