Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveness and Readiness probes #83

Open
RealAnna opened this issue Feb 20, 2023 · 0 comments
Open

Liveness and Readiness probes #83

RealAnna opened this issue Feb 20, 2023 · 0 comments

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Feb 20, 2023

for testing issues, it can be nice to remove readiness and liveness probes completely, but for production I would expect the possibility to customize them 100%

I tried a first solution appending helm ifs statements to the container spec by treating it as a string. This will of course make the container spec impossible to be cast back to corev1.Containers , but as long as this step is done right before the conversion to string of the metadata I see no problems with it...

we do not use startup probes, but maybe this approach could be extended

current implementation here #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant