tagged port set untagged vlan fails

[johanreinalda]

Trying to set a new untagged vlan on a tagged port:

Hardware: CX6300, running 10.13.xxxx

Base config:

show runn int 1/1/10
interface 1/1/10
  no shutdown
  no routing
  vlan trunk native 888
  vlan trunk allowed all
exit

After using following code fragment below, port has all vlans removed, except for untagged:

show runn int 1/1/10
interface 1/1/10
  no shutdown
  no routing
  vlan trunk native 999
  vlan trunk allowed 999
exit

Here is the code fragment:

session = Session(ip_address=device_ip, api=API_VERSION)
session.open(username=username, password=password)

iface = Interface(session=session, name=interface_name)
# materialize the attributes:
iface.get()
print(f"Get() vlan_trunks: {pprint.pformat(iface.vlan_trunks)}")

# materialize the attributes:
iface.get(selector="writable", depth=4)
print(f"Get(selector) vlan_trunks: {pprint.pformat(iface.vlan_trunks)}")


iface.set_native_vlan(vlan=int(new_vlan_id), tagged=False)

session.close()

This appears to be because the "iface.vlan_trunks" never gets set (materialized?), and therefor the iface.set_native_vlan() behaves by adding only the new vlan (see interface.py)

Program output:

Get() vlan_trunks: []
Get(selector) vlan_trunks: []

I have tried this with various selector types ("configuration", "writable"), but it makes no difference...
So, how do I get an Interface() object properly materialized to be able to make this change ?

In reference, this is to support the AOS-CX driver in

https://github.com/openl2m/openl2m/blob/development/openl2m/switches/connect/aruba_aoscx/connector.py

[johanreinalda]

Further testing:

when this is the config:

trunk vlan allowed 888,999

Then I get the following for iface.vlan_trunks:

Get() vlan_trunks: [<pyaoscx.vlan.Vlan object at 0x7fcb5b79b150>, <pyaoscx.vlan.Vlan object at 0x7fcb5b799290>]

I.e. is appears that 'trunk vlan allowed all' produces an empty set, where specific allowed vlans is OK...

Is this expected behaviour? and if so, should interface.py be adjusted to account for that ?

[alagoutte]

Hi johan,

Yes after a quick look, there is no check when using all vlan (vlan_trunks is empty array) -> https://github.com/aruba/pyaoscx/blob/master/pyaoscx/interface.py#L1568 -> need to modified this @alvinc13

Do you have try to use configure_l2_interface ? ansible module is this

[johanreinalda]

I've worked around this.

My applications reads all interfaces from Interfaces().get_facts(). This is then cached as needed. Note that get_facts() expands the vlans allowed, and returns 'vlan_trunks' not as [], but as a dict() with each allowed vlan as key.

So when I change an interface with .get() I am now looping through those allowed vlans and adding, similar to below:

trunk_vlans = []
for vlan in allowed_vlans:
v = Vlan(vlan.id)
trunk_vlans.append(v)

iface.vlan_trunks = vlan_trunks
iface.set_native_vlan()

This works.

I still think you do need to fix the set_native_vlan() code in the interface.py module, similar to what is in configure_l2_interface()

[alagoutte]

Yes, need to be fixed !