Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS styling the HTML representation of InferenceData #58

Open
sethaxen opened this issue Jul 6, 2023 · 1 comment
Open

CSS styling the HTML representation of InferenceData #58

sethaxen opened this issue Jul 6, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sethaxen
Copy link
Member

sethaxen commented Jul 6, 2023

We use <details> to enclose the plaintext representation of the groups in the custom InferenceData HTML show method. By default, the group name is styled with the right-facing arrow to the far left, which rotates to point down when the group is expanded. However, the CSS of the page in which the InferenceData's HTML is inserted might custom style the <details> to remove the arrow. Jupyter does this, for example.

We should embed whatever CSS is necessary in a <style> block after the HTML to ensure that at least in Jupyter the arrow is shown correctly, but it's better if we can style the <details> to show the error no matter what the global CSS is.

Related, each of our tags should probably have a custom class associated with it, which would allow others to style our HTML as they prefer.

@sethaxen
Copy link
Member Author

sethaxen commented Jul 9, 2023

Relates #10

@sethaxen sethaxen added enhancement New feature or request good first issue Good for newcomers labels Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant