Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support testing other GPD fitting methods #24

Open
sethaxen opened this issue Jan 6, 2022 · 0 comments
Open

Support testing other GPD fitting methods #24

sethaxen opened this issue Jan 6, 2022 · 0 comments

Comments

@sethaxen
Copy link
Member

sethaxen commented Jan 6, 2022

There are a number of methods in the literature for fitting the generalized Pareto distribution. We currently implement both the methods of Zhang & Stephens, 2009 (used in the PSIS paper) and Zhang, 2010, which makes some improvements for k>1. Switching between these two is supported by the improved keyword. This is not well named, as it gives the impression that the Zhang, 2010 method is universally better (for k ∈ (0, 1), the range for which smoothing can help the most, it generally is not). These methods are relatively simple to implement and work well; some others would require heavier dependencies like Optim.jl and may be more costly.

It would be preferable to support easily adding new fitting methods, via something like a gpd_fit_method keyword, which might take a symbol or a singleton object as value. Internally, we should dispatch on this keyword.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant