Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maven bug 419 #447

Closed
wants to merge 2 commits into from
Closed

Conversation

idhamari
Copy link
Contributor

@idhamari idhamari commented Apr 5, 2023

fix maven bug

Tested on both Windows 10 and Ubuntu 22.04

@prasser
Copy link
Collaborator

prasser commented Apr 5, 2023

Why have you changed compile to install? I think that this change should be reverted.

@idhamari
Copy link
Contributor Author

idhamari commented Apr 5, 2023

Why have you changed compile to install? I think that this change should be reverted.

As I understand, the goal is to use the library in a different project (probably another maven project). Using install will also add the library to maven local repository which saves time. If you wish, I can replace install with compile

@prasser
Copy link
Collaborator

prasser commented Apr 5, 2023

Yes, please.

@prasser
Copy link
Collaborator

prasser commented Apr 5, 2023

Downgrading POI from 4.1.1 to 3.10-FINAL is not an option due to the large number of vulnerabilities in this version. See here:

https://mvnrepository.com/artifact/org.apache.poi/poi

Maybe the other POI-related libraries also need to be updated. Or POI underwent an API-breaking change and ARX needs to be updated to work with never versions?

@idhamari
Copy link
Contributor Author

idhamari commented Apr 5, 2023

Downgrading POI from 4.1.1 to 3.10-FINAL is not an option due to the large number of vulnerabilities in this version.

I noticed 3.10libs are used in the ant build here

ARX needs to be updated to work with newer versions?

I like this option.

@prasser
Copy link
Collaborator

prasser commented Apr 5, 2023

I noticed 3.10libs are used in the ant build here

I know. Those should be updated as well.

ARX needs to be updated to work with newer versions?

I like this option.

Then go for it! ;)

@idhamari
Copy link
Contributor Author

idhamari commented Apr 5, 2023

ok, I will do this during the weekend :)

@prasser
Copy link
Collaborator

prasser commented Apr 5, 2023

Needs to be revised

@prasser prasser closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Maven build is broken
2 participants