Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 mp4 file when download one completed,there is no obvious indication that one of them has been downloaded. #164

Open
JSZMonkey opened this issue Jan 10, 2019 · 5 comments

Comments

@JSZMonkey
Copy link

When a seed file contains 2 mp4 files, I only download one. When one of the downloads is completed, there is no obvious indication that one of them has been downloaded.

@asapach
Copy link
Owner

asapach commented Jan 10, 2019

Yeah, the only indication is that the checkbox next to the file becomes unchecked. It's the consequence of using torrent-stream under the hood, because it doesn't provide any kind of api for this. I was thinking that instead of unchecking the checkbox I could try to make it checked and disabled, like this:
image
Thoughts?

@JSZMonkey
Copy link
Author

JSZMonkey commented Jan 10, 2019

I think , don't add links without downloading and add Videos.mp4 tag, only have links to files when the file is downloaded and add .
And add a single file delete button, when I click the wrong download, I can delete this file.
And add the automatic transcoding function after the download is completed, and convert the video file format to mp4.

ps: like this

@asapach
Copy link
Owner

asapach commented Jan 10, 2019

Sorry, but I disagree:

don't add links without downloading

The whole point of streaming torrents is that you don't need to download the whole file in order to access it. You can randomly seek inside the file that is partially downloaded.

add a single file delete button

Unfortunately files cannot be deleted once they are downloaded. You can only delete the entire torrent. That's how torrent clients are supposed to work, because they need to be able to seed the downloaded chunks.

add the automatic transcoding function

I've tried that a couple of years ago and it didn't work very reliably for real-time streaming, so I just gave up. I'm not planning to add any special handling for video files. I recommend using VLC to play the video files as network streams.

@nk932714
Copy link

@asapach can't we replace the tick mark with This type of downloading GIF ?
wip-bouncing-arrow-animation

and on downloading completion gif changes to this type of logo?
image

@asapach
Copy link
Owner

asapach commented Jan 16, 2020

@nk932714, the checkbox is meant to convey that the file is currently being downloaded (see here): if it's checked then somebody is interested in it (you can either check it manually, or it will activate automatically when streaming), otherwise it's idle. Replacing it with a gif won't make any functional difference and will only annoy people who hate animated gifs.
I'll think about what can be done better when the download completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants