Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scholix does not capture the "added" and "removed" link action types. #1

Open
krzysztof opened this issue Oct 9, 2017 · 2 comments

Comments

@krzysztof
Copy link
Member

Scholix definition does not seem to capture that once broadcasted relation can be "removed". This is fine if the model aims at describing the state which is to be queried from the HUB by parties (lack of relation is implicit to its removal), however it's not sufficient if the state changes are to be broadcasted through webhooks.

@lnielsen
Copy link

The scholix model just defines a link between two entities, so the information about addition/deletion should be captured by the transport protocol of the link. E.g if OAI-PMH is the transport protocol, then that will provide you with both added and removed links. Similarly, when using webhooks, it's the "webook scholix transport protocol" that needs to define this information.

I think we kind of captured this in having the events that define e.g. the type, id, timestamp etc, and then a payload of the event. So the event woudl be "link_added" "link_removed" and the payload would contain the link in question.

@krzysztof
Copy link
Member Author

{
    “event_id”: "33bace47-dd2e-4fd7-bc02-b5c1c980c3d4",
    "time": 1507214201.550862,
    “event_type”: “relation_created”,
    “source”: “Zenodo”
    “payload”: {...}  # scholix model
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants