Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add asdf-plugin-manager plugin #868

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

aabouzaid
Copy link
Contributor

Summary

Hi 👋

I'd like to add asdf-plugin-managerl to this repository.

Description:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/asdf-plugin-manager
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@aabouzaid aabouzaid requested a review from a team as a code owner August 9, 2023 16:13
@jthegedus
Copy link
Contributor

I am going to merge this but want to be very clear that this plugin does not address any of the underlying design issues with the core or concerns of maintainers about how to properly solve this problem. So as a notice, a solution in the core may conflict with this and break peoples systems in future.

@jthegedus jthegedus merged commit fbc76d7 into asdf-vm:master Sep 10, 2023
@aabouzaid
Copy link
Contributor Author

@jthegedus Yeah, that's a layer to fix the issue externally. If asdf provided a built-in solution, then asdf-plugin-manager would be obsolete, and there would be no need for it anyway.

@jthegedus
Copy link
Contributor

Given the volume of people wanting this feature I imagine you will see a decent amount of adoption. So if/when it becomes obsolete it will cause a decent amount of tech debt. A migration script would probably be needed to help those migrate. Looking at your profile, you seem very familiar with open source and the dangers of committing to supporting software publicly 💯 Appreciate the work 👏

mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants