Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate bin & pipx to new username #891

Merged
merged 3 commits into from
Nov 9, 2023
Merged

fix: migrate bin & pipx to new username #891

merged 3 commits into from
Nov 9, 2023

Conversation

yozachar
Copy link
Contributor

@yozachar yozachar commented Oct 3, 2023

Summary

Description:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@yozachar yozachar requested a review from a team as a code owner October 3, 2023 09:50
@jthegedus
Copy link
Contributor

@yozachar Please explain why these should be changed?

@yozachar
Copy link
Contributor Author

yozachar commented Nov 9, 2023

@jthegedus I changed by GitHub username from @joe733 to @yozachar.

  • In case redirections from former username fails or someone else acquires the same, asdf plugin installation will fail.
  • The status badges probably won't work for long with the older username.

Oh and these, in .tool-versions file:

nodejs     18.18.0
shellcheck 0.9.0
shfmt      3.7.0
  1. Because the current node-js LTS version is 20.9.0. Shall I bump version?
  2. Latest version of shfmt is 3.7.0 and
  3. Formatting looks better.

@jthegedus
Copy link
Contributor

thanks for clarifying

@jthegedus jthegedus merged commit 3594ba8 into asdf-vm:master Nov 9, 2023
4 checks passed
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants