Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return type defined in implicit_mount.ImplicitMount.ls #6

Open
asgersvenning opened this issue Jun 4, 2024 · 0 comments
Open
Assignees
Labels
good first issue Good for newcomers invalid This doesn't seem right

Comments

@asgersvenning
Copy link
Owner

The type declaration for the return type of implicit_mount.ImplicitMount.ls is wrong:

    def ls(self, path: str = ".", recursive: bool=False, use_cache: bool=True) -> List[str]:

Should be:

    def ls(self, path: str = ".", recursive: bool=False, use_cache: bool=True) -> Optional[Union[List[str], str]]:
@asgersvenning asgersvenning added good first issue Good for newcomers invalid This doesn't seem right labels Jun 4, 2024
@asgersvenning asgersvenning self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant