Intermittent Rewrite.SourceError during app creation

[brunoripa]

Describe the bug

I am creating a new Phoenix app and it fails with the following message:

* ash.codegen add_authentication_resources

Proceed with changes? [y/n] y

This command is successfully executed, and then I try to execute `mix igniter.new test_app --install ash,ash_authentication_phoenix --with phx.new`

Issues:

* ** (Rewrite.SourceError) could not write to file "lib/test_app/application.ex": file changed since reading

To Reproduce

I installed Igniter by executing mix archive.install hex igniter_new which installed version 0.5

The next command is mix igniter.new test_app --install ash,ash_authentication_phoenix --with phx.new, which frequently ends up with the reported error.

Expected behavior

A successful app creation, ready to get started

** Runtime

• Elixir version

Erlang/OTP 27 [erts-15.2] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [jit:ns]

Elixir 1.17.3 (compiled with Erlang/OTP 27)

• Erlang version

Erlang/OTP 27 [erts-15.2] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [jit:ns]

Eshell V15.2 (press Ctrl+G to abort, type help(). for help)

• OS

Edition	Windows 11 Home
Version	22H2
Installed on	‎8/‎19/‎2022
OS build	22621.4387
Experience	Windows Feature Experience Pack 1000.22700.1047.0

• Igniter version

0.5.0

• any related extension versions

Additional context

The same command happens to work every now and then, making me think about some sort or race condition.

[zachdaniel]

Hmm... I wonder if this may be OS specific to do with how we check if a file has been modified. Do you have access to a linux or Mac machine to try this on? I can't reproduce.

[brunoripa]

Yes, I should be able to give this a go on Mac and Linux, I'll just need some time. I'll update the ticket asap. Thanks @zachdaniel

[brunoripa]

I just tried on Linux Mint:

Linux mint 6.8.0-47-generic #47-Ubuntu SMP PREEMPT_DYNAMIC Fri Sep 27 21:40:26 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

it worked nicely.

[brunoripa]

@zachdaniel, I confirm that I have the same issue in MacOS.

Elixir: 1.16.2
Erlang: OTP 26

Machine: Apple M2 (any other info needed) ?

[brunoripa]

Also the file causing the failure is somehow different, I have seen application.ex, repo.ex, and others, random mostly. And sometimes I see a specular error:

Issues:

* Required lib/test_app2/application.ex but it did not exist

So not a problem about a file being changed, but about a file not being there.

[zachdaniel]

@hrzndhrn can you think of a reason this might happen on windows? As far as I can tell this is coming from our call to Rewrite.write_all. Perhaps file timestamps are less reliable on windows?