Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAll with casting fails in some cases #20

Open
ashblue opened this issue May 29, 2024 · 0 comments
Open

GetAll with casting fails in some cases #20

ashblue opened this issue May 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ashblue
Copy link
Owner

ashblue commented May 29, 2024

When calling GetAll<T> with an item entry type (line 180). The cast will fail if you're using a custom item entry type and a custom item entry type that forks the base item entry. A LINQ cast is being made and it needs to be converted to a cast type that takes into account potential failure of the conversion.

// Add the items
inventory.Add(generic default item)
inventory.Add(new custom item entry)

// This now fails
var myCustomEntries = inventory.GetAll<MyCustomItemEntry>();
@ashblue ashblue added the bug Something isn't working label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant