Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin style guide violations #1

Open
m7mdkamal opened this issue Aug 21, 2019 · 6 comments
Open

Kotlin style guide violations #1

m7mdkamal opened this issue Aug 21, 2019 · 6 comments

Comments

@m7mdkamal
Copy link

m7mdkamal commented Aug 21, 2019

This line exceeds the maximum recommended length of 100 chars
https://developer.android.com/kotlin/style-guide#line_wrapping

fun provideProductsDatabase(context: Context): LocalDatabase = LocalDatabase.getInstance(context)

Please take this kind of rules more seriously. This affects the whole team.

@m7mdkamal
Copy link
Author

@Abdelrhmanwalid
Copy link

@ashraf-atef
Copy link
Owner

ashraf-atef commented Aug 21, 2019 via email

@m7mdkamal
Copy link
Author

What function name??
How about doing that?
https://kotlinlang.org/docs/reference/coding-conventions.html#expression-body-formatting

@noureldeen-abouelkassem

Too many empty lines.
Please check Connection Error, Activity Builder, App Module and Data Activity classes

@Abdelrhmanwalid
Copy link

Any idea when this issue might get fixed? This is stopping us from adopting this project in our codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants