Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly calculate new_high_sigma #714

Merged
merged 12 commits into from
Jan 29, 2025
Merged

Correctly calculate new_high_sigma #714

merged 12 commits into from
Jan 29, 2025

Conversation

ddobie
Copy link
Contributor

@ddobie ddobie commented May 23, 2024 •
edited
Loading

Fix #713.
Fix #732.

@ddobie ddobie added the do not merge Do not merge this PR label Oct 14, 2024
@ddobie ddobie requested a review from mauch October 17, 2024 02:51
mauch
mauch approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@mauch mauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo and a question.

vast_pipeline/pipeline/new_sources.py Outdated Show resolved Hide resolved
vast_pipeline/pipeline/new_sources.py Outdated Show resolved Hide resolved
@ddobie ddobie added the v2.0 label Jan 28, 2025
@ddobie ddobie changed the base branch from dev to v2.0 January 28, 2025 01:02
@ddobie
Copy link
Contributor Author

ddobie commented Jan 29, 2025

This should be fine now, just waiting on #800 to remove the vaex dependency.

@ddobie ddobie merged commit 162270f into v2.0 Jan 29, 2025
4 checks passed
@ddobie ddobie deleted the fixx-iss-713 branch January 29, 2025 06:06
This was referenced Jan 29, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauch mauch mauch approved these changes

Assignees
No one assigned
Labels
do not merge Do not merge this PR v2.0
Projects
Pipeline Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor pipeline.new_sources.new_sources pipeline.new_sources: New high sigma is actually the new low sigma
2 participants
@ddobie @mauch