Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Model] Added the ability to associate labels with a model #227

Closed
wants to merge 5 commits into from
Closed

[WIP] [Model] Added the ability to associate labels with a model #227

wants to merge 5 commits into from

Conversation

Brett-Parker
Copy link
Collaborator

Resolves

Fixes #163

Description

Added model label

@Brett-Parker
Copy link
Collaborator Author

@aslotte Ready for review, along the right lines or not what you were thinking?

@Brett-Parker Brett-Parker changed the title Added model label [Model] Added the ability to associate labels with a model Jul 22, 2020
@Brett-Parker Brett-Parker requested a review from aslotte July 22, 2020 19:56
@Brett-Parker
Copy link
Collaborator Author

Brett-Parker commented Jul 22, 2020

I actually think this should be stored in the irun repo rather than its own and on the model not the evaluation.

@aslotte
Copy link
Owner

aslotte commented Jul 22, 2020

What do you think @Brett-Parker, does it make the most sense to associate a label with an artifact or with an actual registered model? I'm thinking it may make sense to maybe make the association with the RegisteredModel (which I've yet to finalize the implementation for, sorry about that)

@Brett-Parker
Copy link
Collaborator Author

The more I think about it. Labels are only relevant on the registered model imo. I think it's a nice to have elsewhere but probably not used as often. I committed this, went away and now think this isn't a good approach. Sorry if its taken up your time @aslotte

@aslotte
Copy link
Owner

aslotte commented Jul 22, 2020

Not at all. We can keep this PR open if you like and re-purpose it once we got the RegisteredModel PR done (hopefully on Saturday). It's a great functionality to have later though.

@Brett-Parker Brett-Parker changed the title [Model] Added the ability to associate labels with a model [WIP] [Model] Added the ability to associate labels with a model Jul 26, 2020
This reverts commit 7e93577.
@aslotte aslotte added this to the v0.3.1 milestone Aug 1, 2020
@aslotte aslotte modified the milestones: v0.3.1, v1.1.0 Aug 9, 2020
@aslotte aslotte modified the milestones: v1.1.0, v1.2.0 Aug 16, 2020
@aslotte
Copy link
Owner

aslotte commented Aug 17, 2020

@Brett-Parker I've changed the default branch to main, so given that this PR is on the old master branch I'm going to close it for. Feel free to apply the changes to the new main branch and open a new PR :)

@aslotte aslotte closed this Aug 17, 2020
@Brett-Parker Brett-Parker deleted the Issue_163 branch October 3, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Model] Add the ability to associate labels with a model
2 participants