-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Model] Added the ability to associate labels with a model #227
Conversation
@aslotte Ready for review, along the right lines or not what you were thinking? |
I actually think this should be stored in the irun repo rather than its own and on the model not the evaluation. |
What do you think @Brett-Parker, does it make the most sense to associate a label with an artifact or with an actual registered model? I'm thinking it may make sense to maybe make the association with the |
The more I think about it. Labels are only relevant on the registered model imo. I think it's a nice to have elsewhere but probably not used as often. I committed this, went away and now think this isn't a good approach. Sorry if its taken up your time @aslotte |
Not at all. We can keep this PR open if you like and re-purpose it once we got the RegisteredModel PR done (hopefully on Saturday). It's a great functionality to have later though. |
This reverts commit 7e93577.
@Brett-Parker I've changed the default branch to main, so given that this PR is on the old master branch I'm going to close it for. Feel free to apply the changes to the new main branch and open a new PR :) |
Resolves
Fixes #163
Description
Added model label